Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): resolve OpenTelemetry warnings and token type error #3889

Closed
wants to merge 3 commits into from
Closed

fix(tracing): resolve OpenTelemetry warnings and token type error #3889

wants to merge 3 commits into from

Conversation

Malagurti
Copy link

Description

  • Fix try_get_openai_tokens method indentation causing AttributeError
  • Convert all token values to float type to resolve OpenTelemetry warnings
  • Improve error handling in token collection methods
  • Add safe type conversion for dictionary and None values
  • Ensure consistent numeric values for all token fields
  • Fix token inheritance between parent/child spans

Fixes: #3880 #3888

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Malagurti Malagurti requested a review from a team as a code owner December 19, 2024 22:14
@Malagurti
Copy link
Author

@microsoft-github-policy-service agree

@Malagurti Malagurti changed the title fix(tracing): resolve OpenTelemetry token type warnings fix(tracing): resolve OpenTelemetry warnings and token type error Dec 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Jan 3, 2025
@Malagurti Malagurti closed this Jan 6, 2025
@Malagurti Malagurti reopened this Jan 14, 2025
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue/pull request label Jan 14, 2025
@github-actions GitHub Actions
Copy link

SDK CLI Global Config Test Result main

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4c3999c.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2025

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Feb 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
external no-recent-activity There has been no recent activity on this issue/pull request promptflow-tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Can not turn off telemetry and telemetry logs
1 participant
@Malagurti